test: cover lifetime usage counters and last-settlement timestamps#68
Merged
mikewheeleer merged 1 commit intoJun 24, 2026
Conversation
Locks down the invariant that settle drains per-pair usage but never resets TotalUsageByAgent / TotalRequestsAllTime, and that LastSettlement distinguishes None (never settled) from Some(0). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19.
Summary
Adds coverage for
TotalUsageByAgent,TotalRequestsAllTime, andLastSettlement(read viaget_total_usage_by_agent,get_total_requests_all_time,get_last_settlement).What's covered
TotalRequestsAllTimesumming across agents.settle(which only drains the per-pair counter); re-recording after settle keeps growing them.get_last_settlementisNonebefore any settle andSome(timestamp)after, driven byenv.ledger().with_mut;NonevsSome(0)distinction asserted.Tests
Test-only change.
Security notes
Settlement never silently loses lifetime analytics: per-pair drain and lifetime accumulation are independent storage slots.