test: cover admin transfer edge cases and migration version guard#69
Merged
mikewheeleer merged 1 commit intoJun 24, 2026
Conversation
Adds tests for cancel_admin_transfer, wrong-caller accept (Agentpay-Org#6), re-proposing over a pending entry, post-rotation admin authority, and the migrate_v1_to_v2 double-run guard (Agentpay-Org#11). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20.
Summary
Extends coverage of the two-step admin handover and the schema migration guard beyond the existing happy-path.
What's covered
NoPendingAdminTransfer(Add batch record_usage to amortise ledger write cost across many services #5).NotPendingAdmin(Introduce role-based access control beyond the single-admin model #6).get_pending_adminreflects each state.get_schema_versionis 2 after a fresh v2init;migrate_v1_to_v2then panics#11(double-run guard).Tests
Test-only change.
Security notes
The two-step handover is lockout-resistant: a wrong caller cannot claim the role, and a cancel fully clears the pending slot so a stale proposal cannot later be accepted.