fix: support ARM64 hosts in attacker Dockerfile mongosh install - #14
Open
kiandadban wants to merge 2 commits into
Open
fix: support ARM64 hosts in attacker Dockerfile mongosh install #14kiandadban wants to merge 2 commits into
kiandadban wants to merge 2 commits into
Conversation
…wnloading the arm64 mongosh binary on ARM64 build hosts instead of always fetching x64
GoE's Python docker SDK calls images.build() without BuildKit, so TARGETARCH was always unset and the ARM64 fix never activated. uname -m works regardless of build backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by downloading the arm64 mongosh binary on ARM64 build hosts instead of always fetching x64.
Fixes #6
Fix
Uses Docker's built-in
TARGETARCHbuild arg to select the correct mongosh binary (arm64orx64) at build time. On amd64/Linux hosts,TARGETARCHresolves toamd64, soARCHfalls through tox64. No change for existing working builds.Testing
Verified locally on Mac —
docker build -t goe-attacker-test docker/attacker/now completes successfully. Verifiedpytest -m "not docker and not llm"produces identical results