Skip to content

feat(element): Ensure nested elements share parent's page_version#3660

Open
tvdeyen wants to merge 1 commit intomainfrom
validate-parent-element
Open

feat(element): Ensure nested elements share parent's page_version#3660
tvdeyen wants to merge 1 commit intomainfrom
validate-parent-element

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 9, 2026

What is this pull request for?

Add validation that nested elements must have the same page_version_id as their parent element. This enforces data integrity and enables performance optimizations that rely on all ancestors being in the same page version.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner February 9, 2026 09:52
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.49%. Comparing base (28be7b8) to head (6868f92).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3660   +/-   ##
=======================================
  Coverage   97.48%   97.49%           
=======================================
  Files         314      314           
  Lines        8286     8291    +5     
=======================================
+ Hits         8078     8083    +5     
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the validate-parent-element branch 2 times, most recently from e90cc4f to b7081e4 Compare February 9, 2026 14:09
@tvdeyen tvdeyen added this to the 8.1 milestone Feb 9, 2026
@tvdeyen tvdeyen added backport-to-8.1-stable Needs to be backported to 8.1-stable and removed backport-to-8.1-stable Needs to be backported to 8.1-stable labels Feb 9, 2026
@tvdeyen tvdeyen modified the milestones: 8.1, 8.2 Feb 9, 2026
Add validation that nested elements must have the same page_version_id
as their parent element. This enforces data integrity and enables
performance optimizations that rely on all ancestors being in the
same page version.
@tvdeyen tvdeyen force-pushed the validate-parent-element branch from b7081e4 to 6868f92 Compare February 13, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant