Skip to content

perf(mpi): remove the serial O(R·S²) protocol floor from HybridComm - #166

Draft
diagonal-hamiltonian wants to merge 5 commits into
mainfrom
perf/multinode-comm-scaling
Draft

perf(mpi): remove the serial O(R·S²) protocol floor from HybridComm#166
diagonal-hamiltonian wants to merge 5 commits into
mainfrom
perf/multinode-comm-scaling

test(mpi): 🔧 move the branch's HybridComm cases onto main's args bundles

22631cd
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 11, 2026 in 58s

Annotations

Check warning on line 431 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 10 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASF&open=AZ-tDxMiC20taTj0MASF&pullRequest=166

Check warning on line 445 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASH&open=AZ-tDxMiC20taTj0MASH&pullRequest=166

Check warning on line 35 in cpp/monoprop/detail/mpi/CommProfile.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't mix public and private data members.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSaC20taTj0MASd&open=AZ-tDxSaC20taTj0MASd&pullRequest=166

Check warning on line 52 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Class has 42 methods, which is greater than the 35 authorized. Split it into smaller classes.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASA&open=AZ-tDxMiC20taTj0MASA&pullRequest=166

Check failure on line 209 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pp&open=AZ_xgzD_5Od82_2vs9Pp&pullRequest=166

Check warning on line 56 in cpp/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find" that takes a range.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASR&open=AZ-tDxSCC20taTj0MASR&pullRequest=166

Check warning on line 325 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 9 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pr&open=AZ_xgzD_5Od82_2vs9Pr&pullRequest=166

Check failure on line 187 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASD&open=AZ-tDxMiC20taTj0MASD&pullRequest=166

Check warning on line 249 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 9 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pq&open=AZ_xgzD_5Od82_2vs9Pq&pullRequest=166

Check failure on line 162 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pm&open=AZ_xgzD_5Od82_2vs9Pm&pullRequest=166

Check failure on line 253 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASP&open=AZ-tDxMiC20taTj0MASP&pullRequest=166

Check failure on line 203 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pv&open=AZ_xgzD_5Od82_2vs9Pv&pullRequest=166

Check failure on line 134 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pj&open=AZ_xgzD_5Od82_2vs9Pj&pullRequest=166

Check failure on line 178 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASM&open=AZ-tDxMiC20taTj0MASM&pullRequest=166

Check failure on line 250 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASO&open=AZ-tDxMiC20taTj0MASO&pullRequest=166

Check warning on line 177 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 10 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASC&open=AZ-tDxMiC20taTj0MASC&pullRequest=166

Check failure on line 209 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Po&open=AZ_xgzD_5Od82_2vs9Po&pullRequest=166

Check warning on line 52 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this structure so it has no more than 20 fields, rather than the 34 it currently has.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MAR_&open=AZ-tDxMiC20taTj0MAR_&pullRequest=166

Check warning on line 399 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::byte" for byte-oriented memory access.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Ps&open=AZ_xgzD_5Od82_2vs9Ps&pullRequest=166

Check failure on line 181 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASN&open=AZ-tDxMiC20taTj0MASN&pullRequest=166

Check failure on line 432 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pt&open=AZ_xgzD_5Od82_2vs9Pt&pullRequest=166

Check failure on line 203 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pn&open=AZ_xgzD_5Od82_2vs9Pn&pullRequest=166

Check warning on line 94 in cpp/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASS&open=AZ-tDxSCC20taTj0MASS&pullRequest=166

Check warning on line 119 in cpp/monoprop/detail/mpi/CommProfile.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "start_". Use the in-class initializer instead.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSaC20taTj0MASe&open=AZ-tDxSaC20taTj0MASe&pullRequest=166

Check failure on line 435 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pu&open=AZ_xgzD_5Od82_2vs9Pu&pullRequest=166