fix(cmake): 🐛 enable_testing() before add_subdirectory(cpp) for root ctest - #224
Merged
Conversation
…ctest enable_testing()/include(CTest) lived in cpp/CMakeLists.txt, called after the root CMakeLists.txt had already run add_subdirectory(cpp). CTest's enabled-ness does not propagate back up to an already-processed parent directory, so the root build tree never got a CTestTestfile.cmake and `ctest --test-dir build/editable/Release` (the documented entry point) reported "No tests were found!!!" even though the suite itself passed. Assisted-by: ClaudeCode:claude-sonnet-5
JoshCudbyAlgo
requested review from
diagonal-hamiltonian,
fpietra,
ludmilaasb and
robertodr
as code owners
August 12, 2026 15:23
|
Docs preview: https://pr-224.monoprop-docs.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 14 14
Lines 742 742
Branches 98 98
=======================================
Hits 725 725
Misses 12 12
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
robertodr
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_testing()/include(CTest) lived in cpp/CMakeLists.txt, called after the root CMakeLists.txt had already run add_subdirectory(cpp). CTest's enabled-ness does not propagate back up to an already-processed parent directory, so the root build tree never got a CTestTestfile.cmake and
ctest --test-dir build/editable/Release(the documented entry point) reported "No tests were found!!!" even though the suite itself passed.Changes
Checklist
docs/,CONTRIBUTING.md) if neededCHANGELOG/ release notes updated if applicableAI/LLM disclosure
Important
By opening this PR I confirm that I have read CONTRIBUTING.md and I agree to the terms of the Contributor License Agreement.
Warning
If you're contributing on behalf of your employer, contact cla@algorithmiq.fi to arrange a Corporate CLA.