Homework 1 #9
Open
Homework 1 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostPointer
requested changes
Feb 24, 2024
task_01/src/utils.cpp
Outdated
| #include <vector> | ||
|
|
||
| std::pair<int, int> Func(int number, const std::vector<int> array) { | ||
| int left_ind = 0, right_ind = array.size() - 1; |
Contributor
There was a problem hiding this comment.
давай уже не экономить символы (left_index) и строки (1 объявление 1 строка)
LostPointer
requested changes
Mar 2, 2024
task_01/src/main.cpp
Outdated
| int main() { return 0; } | ||
| #include <bits/stdc++.h> | ||
| #include "utils.hpp" | ||
| using namespace std; |
Contributor
There was a problem hiding this comment.
отделяй пустыми строками блоки кода, да и я не очень одобряю using namespace на весь файл
LostPointer
approved these changes
Mar 23, 2024
Contributor
|
форматеры упали |
LostPointer
reviewed
Mar 30, 2024
LostPointer
reviewed
Apr 13, 2024
task_01/src/utils.cpp
Outdated
| right_index--; | ||
| } | ||
| } | ||
| if (array[left_index] + array[right_index] != number) { |
Contributor
There was a problem hiding this comment.
я бы убрал этот if, что-то поменяется и он не всегда работать будет, тогда функция вернет непонятно что если в этот if не зайдет
LostPointer
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.