GPU TPC: Reject clusters with too small radius during refit instead of giving them IFC mask errors

[davidrohr]

@shahor02 : This should do what you want, but couldn't test it yet since my O2 is not compiling right now. Will fix that and then test it.

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

[davidrohr]

@shahor02 : Please use GPU_rec_tpc.rejectIFCLowRadiusCluster=1.

[shahor02]

Thanks! Will try to test tomorrow.

[davidrohr]

Just tried it, and seems to work. I get same TPC standalone efficiency with somewhat reduced number of clusters, running in MC with larger removal radius. Didn't try with real data. If it works for you, you can just merge it.

[chiarazampolli]

Does not cleanly apply to async-v1-01-branch. For now, I did not add it.

[chiarazampolli]

Hello @shahor02 ,

Why is this flagged for apass4 PbPb 2023? Data were reconstructed without this feature, should we not have MC done in the same way? The fix for the int length was already ported.

Chiara

[chiarazampolli]

Removing async-2024-PbPb-cpass0, since cpass0 is over.

[alcaliva]

Hi @davidrohr,

When I try to port this PR for PbPb apass4 of 2023 data I get conflicts (see below). Can you please have a look and fix it?
Thanks

ERROR: There was a problem cherry-picking dcb767f
Auto-merging GPU/GPUTracking/Definitions/GPUSettingsList.h
CONFLICT (content): Merge conflict in GPU/GPUTracking/Definitions/GPUSettingsList.h
Auto-merging GPU/GPUTracking/Merger/GPUTPCGMTrackParam.cxx
CONFLICT (content): Merge conflict in GPU/GPUTracking/Merger/GPUTPCGMTrackParam.cxx
error: could not apply dcb767f... GPU TPC: Reject clusters with too small radius during refit instead of giving them IFC mask errors
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[shahor02]

@alcaliva I've wrongly added the 2023 apass4 label to this and a few other PRs, I thought @chiarazampolli has already removed it. Doing this now: since the apass4 is over we don't need to backport.