Fix scaling ITS CA tracker params for low Bfield#14042
Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom Mar 11, 2025
Merged
Fix scaling ITS CA tracker params for low Bfield#14042shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02 merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem of missing ITS tracks in the low B-field run was due to the excessive application (in the unrelated loop) of the scaling factor
<1(real_field/5kG) toparam.TrackletMinPt, leading toparam.TrackletMinPt~0.This PR fixes it by applying the factor only once, leading to improved reconstruction (compared to no scaling, red and blue on the plot below).
@mpuccio still, it is not clear why setting the
param.TrackletMinPtclose to 0 leads to the loss of tracks. I guess it is related to linesAliceO2/Detectors/ITSMFT/ITS/tracking/src/TimeFrame.cxx
Lines 419 to 421 in a8f7574