[O2B-1521] Add pagination to QcFlagsForDataPass#2052
Merged
Conversation
Integrated the paginationComponent into QcFlagsForDataPassOverviewPage and passed the pagination model to the view. WITHOUT tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
+ Coverage 45.42% 45.43% +0.01%
==========================================
Files 1028 1028
Lines 17136 17134 -2
Branches 3120 3120
==========================================
+ Hits 7784 7785 +1
+ Misses 9352 9349 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
graduta
requested changes
Jan 8, 2026
| */ | ||
| getLoadParameters() { | ||
| return {}; | ||
| async getLoadParameters() { |
Member
There was a problem hiding this comment.
I believe it is better to simply remove the method declaration so that the parent method kicks in, rather than implementing a call directly to it.
What do you think?
Removed as only called the superclass implementation without modification.
graduta
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated the paginationComponent into QcFlagsForDataPassOverviewPage and passed the pagination model to the view.
WITHOUT tests.
I have a JIRA ticket
Notable changes for users:
qc-flags-for-data-passpageNotable changes for developers:
Changes made to the database: