FIT: add MC aQC for FV0 and FDD

[andreasmolander]

Enable MC aQC for FV0 and FDD. NOTE!!! This needs AliceO2Group/AliceO2#13482 to work!

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

[andreasmolander]

+async-label async-2023-pbpb-apass3, async-2023-pbpb-apass4, async-2023-pp-apass4, async-2024-pp-apass1, async-2022-pp-apass7

[andreasmolander]

I suppose the failing test is because of the still unmerged O2 dependency AliceO2Group/AliceO2#13482

[chiarazampolli]

Hello @marslandALICE ,

Can you help @andreasmolander with testing this PR?

@ktf , @singiamtel, can you check why I cannot access the CI tests?

Thanks,

Chiara

[andreasmolander]

Tested by running O2DPG_pp_minbias.sh locally according to https://github.com/AliceO2Group/O2DPG/tree/master/MC#adding-qc-tasks-to-the-simulation-script with my new enabled QC tasks and with my O2 changes. I passed an own argument with --qcdbHost to the o2dpg_sim_workflow.py script and uploaded the QC results successfully to a local instance of ccdb.

[chiarazampolli]

@singiamtel, now I can see the logs!

@sawenzel , the errors are:

{code}
10-o2dpg_sim_workflow: Error! Interaction rate not >0 !!!
{code}

any idea what is happening?

[chiarazampolli]

Tested by running O2DPG_pp_minbias.sh locally according to https://github.com/AliceO2Group/O2DPG/tree/master/MC#adding-qc-tasks-to-the-simulation-script with my new enabled QC tasks and with my O2 changes. I passed an own argument with --qcdbHost to the o2dpg_sim_workflow.py script and uploaded the QC results successfully to a local instance of ccdb.

Hello @andreasmolander ,

Thanks, I will wait for some feedback by Sandro about the CI, but on Monday I will merge anyway, since the error I see is not related to your PR, unless I am wrong.

Chiara

[sawenzel]

The problems with failing test scripts (missing --interactionRate) should be gone.

[chiarazampolli]

Hello @andreasmolander ,

PR AliceO2Group/AliceO2#13482 was closed. What about this one? It fails I guess because the one in O2 is missing.

Chiara

[andreasmolander]

Hello @andreasmolander ,

PR AliceO2Group/AliceO2#13482 was closed. What about this one? It fails I guess because the one in O2 is missing.

Chiara

Hi @chiarazampolli,

It was closed due to inactivity. It should still be merged. I'll check that AliceO2Group/AliceO2#13482 can still be merged and then reopen it. This PR is also still to be merged.

[andreasmolander]

PR AliceO2Group/AliceO2#13979 replaces the old closed dependency. I.e. that new O2 PR is needed for this PR to work

cc @chiarazampolli

[andreasmolander]

+async-label !async-2022-pp-apass7, !async-2023-pbpb-apass4, !async-2023-pp-apass4, !async-2024-pp-apass1

[andreasmolander]

+async-label async-2024-pbpb-apass4, async-2024-pp-cpass0, async-2024-pp-apass7, async-2024-pp-apass1, async-2023-pbpb-apass3, async-2023-pp-apass4

[github-actions]

Hi @andreasmolander, the following label names could not be recognised: async-2024-pbpb-apass4, async-2024-pp-apass7, async-2023-pbpb-apass3

[andreasmolander]

+async-label async-2023-pbpb-apass4, async-2022-pp-apass7, async-2024-PbPb-apass1, async-2024-ppRef-apass1

[andreasmolander]

Hi @chiarazampolli, the dependency of this PR is merged (AliceO2Group/AliceO2#13979), so this PR would be ready to go now. cc @sahilupadhyaya92

[chiarazampolli]

Hello @andreasmolander ,

Thanks. I don't see issue, but I'd like @JianLIUhep to also take a look.

Chiara

[JianLIUhep]

Hi, @chiarazampolli @andreasmolander, thanks for adding the MC QC workflows. Looks good to me as well.
Cheers,
Jian

[andreasmolander]

Hi @chiarazampolli, can we merge this?

[chiarazampolli]

Merged, thanks!