Skip to content

fix: restore deprecated Bootstrap CSS compatibility constant #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perNyfelt merged 1 commit into from
Aug 4, 2026
Merged

fix: restore deprecated Bootstrap CSS compatibility constant #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions gmd-core/src/main/groovy/se/alipsa/gmd/core/HtmlDecorator.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ class HtmlDecorator {
public static final String HIGHLIGHT_JS_CSS_PATH = "/highlightJs/styles/default.min.css"
public static final String BOOTSTRAP_CSS_PATH = "/META-INF/resources/webjars/bootstrap/5.3.8/css/bootstrap.css"

/**
* The external URL of the Bootstrap stylesheet.
*
* @deprecated Use {@link #BOOTSTRAP_CSS_PATH} when referring to the classpath resource.
*/
@Deprecated
public static final String BOOTSTRAP_CSS = resourceUrlExternalForm(BOOTSTRAP_CSS_PATH)

public static final String HTML5_DECLARATION = "<!DOCTYPE html>\n"
static final XHTML_MATHML_DOCTYPE = "<!DOCTYPE html PUBLIC\n \"-//OPENHTMLTOPDF//MATH XHTML Character Entities With MathML 1.0//EN\" \"\">\n"
public static final String OPENHTMLTOPDF_DECLARATION = "<!DOCTYPE html PUBLIC\n\"-//OPENHTMLTOPDF//MATH XHTML Character Entities With MathML 1.0//EN\" \"\">\n"
Expand Down
9 changes: 9 additions & 0 deletions gmd-core/src/test/groovy/test/alipsa/groovy/gmd/GmdTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,15 @@ class GmdTest extends AbstractGmdTest {
assertTrue(present.contains('bootstrap'), present)
}

@Test
void retainsDeprecatedBootstrapCssCompatibilityConstant() {
def resourceUrl = se.alipsa.gmd.core.HtmlDecorator.class
.getResource(se.alipsa.gmd.core.HtmlDecorator.BOOTSTRAP_CSS_PATH)
.toExternalForm()

assertEquals(resourceUrl, se.alipsa.gmd.core.HtmlDecorator.BOOTSTRAP_CSS)
}

@Test
void nullInputIsRejectedClearly() {
def gmd = new Gmd()
Expand Down
Loading