Add the missing 512pt@2x icon for Mac App Store submission - #10
Merged
Conversation
…submission App Store Connect's altool --validate-app rejected the packaged .app with error 90236: 'Missing required icon. The application bundle does not have an icon in ICNS format containing a 512pt x 512pt @2x image.' Rendered at 1024x1024 directly from the existing MarkdownToPdf.svg vector source (sips supports SVG input), added to the iconset, and rebuilt md2pdf.icns with iconutil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarkdownToPdf-dist'sbuild-mas.sh --tagpipeline produces a real, Apple-Distribution-signed build for the first time this session;xcrun altool --validate-appagainst it failed with error 90236: missing a 512pt x 512pt @2x (1024x1024) icon representation, required for Mac App Store submission.md2pdf.iconsetonly had 128/256/512px @1x entries, no @2x sizes at all.icon_512x512@2x.png(1024x1024) directly from the existingMarkdownToPdf.svgvector source and rebuiltmd2pdf.icnswithiconutil.Test plan
iconutil -c iconseton the rebuilt.icnsconfirms the new 1024x1024 entry is presentaltool --validate-appre-run against a rebuilt package (pending, in the sibling dist repo)