fix(smb): migrate to cloudsoda go-smb2 - #9617
Open
mengskysama wants to merge 1 commit into
Open
Conversation
Collaborator
|
The migration itself is clean, and threading ctx through checkConn/initFS reads right. cloudsoda is the fork rclone uses, so this is a good direction, and it should take care of the slice-bounds crash people were hitting. Two things before this goes in:
Assuming CI passes, this is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates the SMB driver from the unmaintained
github.com/hirochachacha/go-smb2module to the actively maintainedgithub.com/cloudsoda/go-smb2fork used by rclone.The old library used server-provided fields such as
FileNameLengthandNextEntryOffsetfor slicing SMB directory response buffers without sufficient bounds validation.This brings in upstream SMB protocol hardening and prevents malformed directory responses from crashing AList with errors sometime such as:
Changes
github.com/hirochachacha/go-smb2with a pinnedgithub.com/cloudsoda/go-smb2revision.Notes