Encode floating point operations as uninterpreted functions#1095
Open
can-leh-emmtrix wants to merge 7 commits intoAliveToolkit:masterfrom
Open
Encode floating point operations as uninterpreted functions#1095can-leh-emmtrix wants to merge 7 commits intoAliveToolkit:masterfrom
can-leh-emmtrix wants to merge 7 commits intoAliveToolkit:masterfrom
Conversation
Member
|
(not forgotten, but review delayed for a few weeks, sorry. PLDI deadline approaching) |
can-leh-emmtrix
commented
Oct 30, 2024
Comment on lines
+260
to
+261
| if (get_uf_float()) | ||
| doesApproximation("uf-float"); |
Contributor
Author
There was a problem hiding this comment.
I am not sure what the best way to handle doesApproximation is with this approach. One option would be to call it in fm_poison in instr.cpp, however we don't have direct access to the UFs anymore. From what I can tell from the source code, the second argument to doesApproximation needs to be the APP node of the UF. However we do not have access to that anymore at this point. It may be possible to obtain the UFs by traversing the AST though. Another option might be to register a callback function with expr.h which is called for each created UF.
Contributor
Author
|
Thanks for letting me know and no worries about the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach based on modifying expr.cpp. Please let me know what you think.
Previous PR: #1057