fix(docker): make kubectl-delivery base image and k8s version configurable#2
Open
vicoooo26 wants to merge 1 commit into
Open
Conversation
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
…rable Add ALPINE_VERSION (default 3.22) and K8S_VERSION (default v1.30.7) as build args so they can be overridden via --build-arg without editing the Dockerfile. Signed-off-by: Vico Chu <vico24826@gmail.com>
vicoooo26
force-pushed
the
fix/kubectl-delivery
branch
from
July 15, 2026 11:46
50b5d5b to
3b339d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes the kubectl-delivery Dockerfile more flexible by extracting hardcoded Alpine and Kubernetes versions into build args:
ALPINE_VERSION(default3.22) — replaces the hardcodedalpine:3.17in both build and final stagesK8S_VERSION(defaultv1.30.7) — replaces the hardcodedENV K8S_VERSIONwith anARG, allowing override via--build-argThis also upgrades the Alpine base from 3.17 to 3.22, bringing security fixes and updated packages. Both values can now be overridden at build time without editing the Dockerfile.