Shader rotation - #171
Merged
Merged
Conversation
RoboDoig
force-pushed
the
shader-rotation
branch
from
September 4, 2026 19:31
f45b1af to
ad94c1c
Compare
Collaborator
Collaborator
Author
|
@micahwoodard - yes potentially, I've just left flip and rotation options as properties of the visualizers for now so should be easy enough to wire them in from the config. |
bruno-f-cruz
approved these changes
Sep 10, 2026
bruno-f-cruz
left a comment
bruno-f-cruz
left a comment
Member
There was a problem hiding this comment.
Looks good. We can keep improving if needed later! Thanks @RoboDoig !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses comments in #139 and implements image rotation and flipping in the shader pass to avoid allocations from the
FlipandWarpAffineoperators.Rotation is not locked and is set with a radians property in the
CameraPreviewVisualizer. Horizontal and Vertical flips are represented by a boolean property