manage multiple waste outputs according to chemical compatibility - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Jobcan run on a machine that can handle the waste.Heads-up! The bulk of the changes are in brainwasher.py and job.py. (You can probably ignore the bulk of the *.yaml file changes.
More detailed changes:
starting_solutionout of the job history field so we can record the solution of the reaction vessel during a pause.Vessel,ReactionVessel, andWasteVesseldataclasses. (Also consolidate them)WasteVessels accept a set of all the chemicals you can fill them with.get_compatible_waste_vessel_idmethodJobpydantic model.Reviewing
Heads up! If you're curious about liquid-handling functions like
prime_reservoir_line,drain_vessel, orrun_wash_step, let's do a demo or walk through the code together! The next best thing is to reference this P&ID diagram.Testing:
TODO
reconstitute starting state knowing the contents of all vessels in the event of a power failure or crash.<-- punt this for later after we wrap up chemistry tests. (Kevin and I can always recover the machine from a power failure / crash without additional features. (See: Save/Reconstitute Starting State #24 for requirements.)