Skip to content

Feat seqflow pump - #58

Open
hannalee2 wants to merge 23 commits into
feat-seqflow-devicefrom
feat-seqflow-pump
Open

Feat seqflow pump#58
hannalee2 wants to merge 23 commits into
feat-seqflow-devicefrom
feat-seqflow-pump

Conversation

@hannalee2

Copy link
Copy Markdown
Collaborator

Updates

Updated SeqFlow to use the MasterSense pump, which is a new pump device for BARseq system
https://alleninstitute.sharepoint.com/:b:/s/Instrumentation/IQCRUIqMw-uzTqy_y4X4Z6hhAXHhgutepQd5IR47IiprbMo?e=RGJo1Y

Hardware Driver Integration:

  • Added low-level serial drivers for MasterSense pump hardware.
  • Removed the pump_vol() function from previous sim device. Control logic now use explicit start_pump and stop_pump calls.
  • Added core Pump device APIs and wired them directly into the seqflow instrument level.

Fixed Issues

Merge Checklist

  • update the changelog
  • bump the version

@micahwoodard micahwoodard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some file organization questions but functionally makes sense :)

Comment thread instruments/seqflow/src/seqflow/seqflow.py
Comment thread instruments/seqflow/src/seqflow/seqflow.py Outdated
Comment thread src/mixology/devices/pump/ismatec_master_sense.py Outdated
Comment thread src/mixology/devices/pump/ismatec_master_sense.py Outdated
Comment thread src/mixology/devices/pump/peristaltic_pump.py
Comment thread src/mixology/devices/pump/peristaltic_pump.py Outdated
@hannalee2
hannalee2 marked this pull request as draft August 27, 2026 13:49
@hannalee2
hannalee2 requested a review from micahwoodard August 27, 2026 16:31
@hannalee2
hannalee2 marked this pull request as ready for review August 27, 2026 16:31
@hannalee2

Copy link
Copy Markdown
Collaborator Author

Had some file organization questions but functionally makes sense :)

Thanks! Yes, we should definitely tackle the file organization at some point. I was honestly a bit confused about the best place to put the simulated drivers, base drivers, and the actual hardware drivers. Right now it's a bit inconsistent—some base classes are under devices/, while others are nested under specific drivers. Let's plan to standardize that in a future PR.

@micahwoodard micahwoodard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing questions. Looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants