Feat seqflow pump - #58
Open
hannalee2 wants to merge 23 commits into
Open
Conversation
… peristaltic pump
hannalee2
requested review from
Poofjunior,
jessy-liao,
mah1329,
micahwoodard and
patricklatimer
August 26, 2026 21:23
micahwoodard
left a comment
Contributor
There was a problem hiding this comment.
Had some file organization questions but functionally makes sense :)
hannalee2
marked this pull request as draft
August 27, 2026 13:49
One config and one file makes sense for device spinner
Move ABC pump into pump/ and use 1 low level driver only without wrapper
hannalee2
marked this pull request as ready for review
August 27, 2026 16:31
Collaborator
Author
Thanks! Yes, we should definitely tackle the file organization at some point. I was honestly a bit confused about the best place to put the simulated drivers, base drivers, and the actual hardware drivers. Right now it's a bit inconsistent—some base classes are under devices/, while others are nested under specific drivers. Let's plan to standardize that in a future PR. |
micahwoodard
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Updated SeqFlow to use the MasterSense pump, which is a new pump device for BARseq system
https://alleninstitute.sharepoint.com/:b:/s/Instrumentation/IQCRUIqMw-uzTqy_y4X4Z6hhAXHhgutepQd5IR47IiprbMo?e=RGJo1Y
Hardware Driver Integration:
Fixed Issues
Merge Checklist