Feat seqflow recipe - #59
Conversation
Ohter devices such as heat or incubation wait does not need to specify flow_rate
When job is finished, purge solution so that next job can be run. Slide is free-flow no need to check the previous solution is same as starting solution
| @@ -0,0 +1,66 @@ | |||
| name: "User Defined 01" | |||
There was a problem hiding this comment.
Should these protocols live somewhere like zookeeper or the local files? Feels weird to have them in the repo
There was a problem hiding this comment.
That's a great point. These are essentially static baseline protocols that won't change, so having them version-controlled in the repo makes sense for consistency. Xiayin's team receives these protocols from the chemistry team and wants to prevent users from altering them, meaning the files need to stay exactly as they are. I agree that if we need to update them frequently in the future, we can definitely migrate them to Zookeeper or an external store.
If it is only for uder defined01.yml, I will follow up what is this file for.
There was a problem hiding this comment.
I checked with Xiaoyin, and it turns out user_defined01.yml is treated like protocol files, which is rarely edited.
I will keep it in the protocols/ directory with the others, but I will rename it to something more descriptive so it doesn't look like a local user file. Xiaoyin will rename the file in the future and I will update accordingly.
There was a problem hiding this comment.
After talking with Xiaoyin, he wants to keep a set of template protocols in the repo and store the actual protocols as local files. I think this structure will work well for this case. Let me know what you think. :) Thank you!
seqflow/
├── src/
│ └── seqflow/
│ └── seqflow.py
├── protocols/ <-- Template protocols (User can tests standalone seqflow using this protocols)
└── pyproject.toml
barseq-instrument/
├── src/
│ └── barseq_instrument/
│ └── main.py
├── protocols/ <-- Actual protocols to run
├── configs/ <-- Config file pointing the protocol files
└── pyproject.toml
|
|
||
| def _get_protocol_dir(self) -> Path: | ||
| """Helper to get the base directory for protocols.""" | ||
| return Path(__file__).parent.parent.parent / "protocols" |
There was a problem hiding this comment.
Would this be better abstracted in the config with this as the override?
Updates
Fixed Issues
Merge Checklist