fix: pass warehouse dialect to altimate-core tools instead of hardcoding snowflake#550
fix: pass warehouse dialect to altimate-core tools instead of hardcoding snowflake#550VJ-yadav wants to merge 1 commit intoAltimateAI:mainfrom
Conversation
…ing snowflake Add optional `dialect` parameter (default: "snowflake") to all 8 altimate-core tools that were missing it: - altimate-core-validate, fix, correct, semantics, equivalence, policy, check, and impact-analysis Each tool now: 1. Accepts `dialect` via its zod parameter schema 2. Passes it through to the Dispatcher call 3. Includes it in telemetry metadata Follows the pattern established in sql-analyze.ts, sql-optimize.ts, and schema-diff.ts. Type interfaces updated in types.ts. Tests updated to pass dialect explicitly. Fixes AltimateAI#455 Co-Authored-By: Vijay Yadav <vijay@studentsucceed.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
1 participant
Summary
Fixes #455 — Adds optional
dialectparameter (default:"snowflake") to all 8 altimate-core tools that were hardcoding it:altimate-core-validate.ts,fix.ts,correct.ts,semantics.ts,equivalence.ts,policy.ts,check.tsimpact-analysis.tsEach tool now accepts
dialectvia zod schema, passes it to the Dispatcher call, and includes it in telemetry metadata. Follows the pattern already established insql-analyze.ts,sql-optimize.ts, andschema-diff.ts.Type interfaces updated in
types.ts. Tests updated to pass dialect explicitly.Test Plan
bun turbo typecheck— 5/5 packages passbun test test/altimate/schema-finops-dbt.test.ts— 56 passbun test test/altimate/tool-error-propagation.test.ts— 22 passdialect: "postgres"and verify it reaches telemetryChecklist