fix: include nested node_modules in NODE_PATH for NAPI resolution#576
fix: include nested node_modules in NODE_PATH for NAPI resolution#576anandgupta42 merged 1 commit intomainfrom
Conversation
After `npm install -g`, `@altimateai/altimate-core` is installed as a dependency of `altimate-code` and lives at `<global_root>/altimate-code/node_modules/`, not at the global root. NODE_PATH must include both paths to handle npm's hoisted and nested layouts. This fixes the sole remaining Verdaccio sanity CI failure (Phase 1 and Phase 1b NAPI binding checks). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 31 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Fixes Verdaccio sanity CI failure where
@altimateai/altimate-coreNAPI binding can't be found afternpm install -g. The module is installed nested at<global_root>/altimate-code/node_modules/butNODE_PATHonly searched the global root.Type of change
Issue for this PR
Closes #575
How did you verify your code works?
bash -nnpm root -greturns/home/testuser/.npm-global/lib/node_modulesbut@altimateai/altimate-corelives at.../altimate-code/node_modules/@altimateai/altimate-coreNODE_PATHin all 3 locations (Phase 1, Phase 1 drivers, Phase 1b)Checklist
🤖 Generated with Claude Code