Skip to content

Fix backup retention logic issues for rsync #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoard wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Fix backup retention logic issues for rsync #1369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/integration/rsync/upload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ done

if [[ "" != "${BACKUP_KEEP_TO_REMOTE}" && "0" != "${BACKUP_KEEP_TO_REMOTE}" ]]; then
BACKUP_LIST=$(${CUR_DIR}/list.sh)
BACKUP_COUNT=$(echo $BACKUP_LIST | wc -l)
if [[ $BACKUP_COUNT > $BACKUP_KEEP_TO_REMOTE ]]; then
let BACKUP_TO_NEED_DELETE=$BACKUP_COUNT - $BACKUP_KEEP_TO_REMOTE
BACKUP_TO_NEED_DELETE=$(echo $BACKUP_LIST | clickhouse-local --input-format="JSONEachRow" -q "SELECT backup_name FROM table ORDER BY creation_date LIMIT ${BACKUP_TO_NEED_DELETE}")
BACKUP_COUNT=$(echo "$BACKUP_LIST" | wc -l)
if [[ $BACKUP_COUNT -gt $BACKUP_KEEP_TO_REMOTE ]]; then
BACKUP_TO_NEED_DELETE=$((BACKUP_COUNT - BACKUP_KEEP_TO_REMOTE))
BACKUP_TO_NEED_DELETE=$(echo "$BACKUP_LIST" | clickhouse-local --input-format="JSONEachRow" -q "SELECT backup_name FROM table ORDER BY creation_date LIMIT ${BACKUP_TO_NEED_DELETE}")
for backup_name in $BACKUP_TO_NEED_DELETE; do
${CUR_DIR}/delete.sh "${backup_name}"
done
Expand Down
Loading