fix: copy models/*.xsd to publish output so XSD validation runs in deployed apps - #1854
Merged
ivarne merged 3 commits intoSep 17, 2026
Merged
Conversation
…ployed apps The Web SDK only copies *.json and *.config files to the build and publish output, so the XSD schemas in models/ never reached the Docker image. With AppSettings:XsdValidation enabled, XsdValidator was registered but IAppResources.GetXsdSchema returned null for every data type and the validator silently skipped them. It only worked when the app ran from its source folder (dotnet run, studioctl). Ship a build/Altinn.App.Api.targets file in the Altinn.App.Api package with a Content rule for models/**/*.xsd so every app picks it up on package upgrade, and log a missing schema as a warning instead of an informational message. The targets file follows the props file through the experimental rename for PR builds. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
/publish |
Member
|
/publish |
1 similar comment
martinothamar
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Web SDK only copies *.json and *.config files to the build and publish output, so the XSD schemas in models/ never reached the Docker image. With AppSettings:XsdValidation enabled, XsdValidator was registered but IAppResources.GetXsdSchema returned null for every data type and the validator silently skipped them. It only worked when the app ran from its source folder (dotnet run, studioctl).
Ship a build/Altinn.App.Api.targets file in the Altinn.App.Api package with a Content rule for models/**/*.xsd so every app picks it up on package upgrade, and log a missing schema as a warning instead of an informational message. The targets file follows the props file through the experimental rename for PR builds.
Verification
Documentation