Conversation
…es as local variables within the subroutines. Made the group ids correspond to their file (index).
…re specific variables on the variables from the mpi module. Added more explicit free-form in gfotran compiler flags.
…re within the mpi preprocessor macro which is enabled through the compilation stage. Therefore another test runner (h5testrunner_mpi) is compiled through the CMakeLists.txt to test mpi functionality. This allows the testing for serial and parallel (mpi) hdf5 APIs. Updated the modhdf5 module to enable independent IO when mpi macros are enabled.
…ad the dxpl within the h5_ids_t type. This bundles the hypersplice/hyperslab mpi dxpl_ids to the corresponding hyper id index (reducing complexity). The non-hyper datasets will use the mpi independent dxpl_id generated within the readHDF5/writeHDF5 arrays. This removes the need of the dxpl_index. The h5_ids_t variables are initialised to -1 to make it easier to close and reset the hypersplice id entries. Also, extracted whether the file is using mpi mode which is then used when setting the the dxpl id. Added a test using openmp parallelisation for the hypersplices. Updated the hypersplice/hyperslab subroutines to open the hypersplice dataset for reading instead of opening the dataset each time the hypersplice array is read. Also moved the configuration of the hypersplice/hyperslab dims and offset into a separate subroutine. Tidied the init/open/read/write subroutines so that all the variable configuration is done and then the h5 subroutines are called. Updated the tests with respect to these modifications. Lastly, the writing to terminal calls and test assertions are now done only on the rank 0 mpi processor (for clarity - mpi tests still use multiple processors when specified).
Add ifx intel compilers to CI (and update CMakeLists.txt), make read/write subroutines in modhdf5 compatible with the intel compilers to avoid IntelLLVM’s restriction on polymorphic assumed-rank dummies + optional arguments. Also adjusted the .inc files and added new ones to be used directly in the readHDF5*/writeHDF5* subroutines. Add further documentation to README.md and comments on the subroutines' dummy inputs and outputs (and some minor docstrings). Tidy variables used in subroutines. Reorder subroutines in modhdf5. Added version global variable to module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge develop commits b37caff to 62d3f2e into main branch