Allow atommap rmsfit to proceed with partial atom maps#1114
Open
drroe wants to merge 2 commits into
Open
Conversation
atoms are mapped (allow it to proceed with whatever is mapped).
when not all atoms mapped.
Contributor
|
@drroe how is Jenkins used nowadays in cpptraj? It seems the build keeps failing in this. |
Contributor
Author
The failure was unusual (a |
Contributor
Contributor
Author
|
It's a real failure: Caused by the changes to the readline includes needed to get cpptraj working with the conda readline. It will require me reworking how the bundled readline is included (I think). I'm testing that in a separate branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.29.8. Previously
atommap rmsfitrequired a full atom mapping to work. This PR changes it so that only the mapped atoms are used in the rms fit. It also adds a check that there are at least 3 mapped atoms for this, and checks forrmsfitandchangenames(the two are mutually exclusive).