Skip to content

Fix copy of Frame information in the 'setvelocity' command #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drroe merged 2 commits into from
Jun 4, 2026
Merged

Fix copy of Frame information in the 'setvelocity' command #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d57479
Use Frame::SetFrame() instead of copying; previously only coordinate …
Jun 4, 2026
579c738
V7.9.0. Minor version bump for SetVelocity fix; all frame info now pr…
Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/Action_SetVelocity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,7 @@ Action::RetType Action_SetVelocity::Setup(ActionSetup& setup) {

// Action_SetVelocity::DoAction()
Action::RetType Action_SetVelocity::DoAction(int frameNum, ActionFrame& frm) {
std::copy( frm.Frm().xAddress(), frm.Frm().xAddress() + frm.Frm().size(), newFrame_.xAddress() );
if (frm.Frm().HasVelocity())
std::copy( frm.Frm().vAddress(), frm.Frm().vAddress() + frm.Frm().size(),
newFrame_.vAddress() );
newFrame_.SetFrame( frm.Frm() );
if (mode_ == ZERO) {
for (AtomMask::const_iterator atom = Mask_.begin(); atom != Mask_.end(); ++atom)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* Whenever a number that precedes <revision> is incremented, all subsequent
* numbers should be reset to 0.
*/
#define CPPTRAJ_INTERNAL_VERSION "V7.8.0"
#define CPPTRAJ_INTERNAL_VERSION "V7.9.0"
/// PYTRAJ relies on this
#define CPPTRAJ_VERSION_STRING CPPTRAJ_INTERNAL_VERSION
#endif
Loading