Conversation
fix(proxy): reject bracketed non-ipv6 no_proxy hosts fix(proxy): harden trust_env proxy parsing fix(proxy): harden trust_env parser contract fix(proxy): harden trust_env resolver security contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
trust_envproxy resolver foundation for FogHTTP.This PR makes
trust_env=Trueaccepted and resolves supported proxy/TLS environment settings once during client configuration. It does not implement actual HTTP proxy routing or HTTPSCONNECTyet; those remain follow-up transport tasks.Changes
foghttp/_client/proxy/.HTTP_PROXY/http_proxyHTTPS_PROXY/https_proxyALL_PROXY/all_proxyNO_PROXY/no_proxySSL_CERT_FILE/ssl_cert_fileHTTP_PROXYin CGI-like environments whenREQUEST_METHODis set.NO_PROXYmatching for wildcard, exact host, suffix, port, localhost, IPv4, and IPv6 rules.SSL_CERT_FILEtoTLSConfigonly when explicittls=is not provided.trust_envargument from the RustRawClientconstructor boundary.Security / Lifecycle Notes
SSL_CERT_DIR, TLS verification disabling, PAC/WPAD, SOCKS, HTTP proxy routing, and HTTPSCONNECTremain unsupported.