Skip to content

feat(skills): add /devflow:review-document for prose-doc review#34

Merged
AndreJorgeLopes merged 2 commits into
mainfrom
feat/review-document-skill
May 28, 2026
Merged

feat(skills): add /devflow:review-document for prose-doc review#34
AndreJorgeLopes merged 2 commits into
mainfrom
feat/review-document-skill

Conversation

@AndreJorgeLopes

Copy link
Copy Markdown
Owner

Summary

New devflow skill /devflow:review-document — multi-perspective review for prose documents (KB articles, RFCs, spikes, runbooks, PRDs, design docs) on Google Docs, Confluence, local files, or arbitrary URLs. Counterpart to the existing /devflow:write-spike (which lives in proof-of-skill). Sibling to /devflow:review (which targets code diffs).

  • Skill core: 6-phase workflow — source detection + CLEAN fetch (strips Google Docs suggestion strikethrough, Confluence change-tracking, Word track-changes), linked-ticket pull, Hindsight recall, existing-comment cross-check (Confluence inline/footer with resolved_state; Google Docs text/plain export embeds [a]/[b]/[c] markers — RAISED-OPEN by default), parallel Task-subagent dispatch with per-DOC_TYPE agent sets, severity scoring + cross-agent dedup + cross-check status (NEW / RAISED-OPEN / RAISED-RESOLVED-FIXED / RAISED-RESOLVED-NOT-FIXED), chat-only output mirroring /devflow:review (emoji severity, bold key terms, TL;DR).
  • Tessl skill review: 90 % — passed create-skill ≥ 85 % gate. Five optimize-skill iterations all kept at plateau (G1: score(N) ≥ score(N-1) for every iteration; G2: score(final) ≥ score(0)). Subagent spec-review surfaced 0 Critical; 4 Important findings applied inline before opening this MR.
  • Soft dependency on upstream defuddle (npm install -g defuddle) — NOT vendored into devflow per design. Falls back to WebFetch when missing. Formula/devflow.rb caveats + install.sh nudge the user.

Files

Path Change
skills/review-document/{SKILL.md, AGENTS.md, TEMPLATES.md} new — skill source (3 bundle files)
devflow-plugin/skills/review-document/… new — plugin mirror
skills/registry.json register skill in code-review category (layer 3)
Formula/devflow.rb defuddle soft-dep in caveats
install.sh optional defuddle check at end of installer
README.md skills-table row (18 → 19 commands), prerequisites note defuddle as optional
visualizations/architecture/code-review-architecture.md new section 5 with full Mermaid flow for /devflow:review-document
visualizations/architecture/devflow-ecosystem.md commands-table row added

Validated against real-world doc

Tested on a customer-facing WhatsApp Usernames KB draft (Google Doc). Phase 0b clean-fetch via download_file_content text/plain stripped Google Docs suggestion-mode strikethrough cleanly (raw read_file_content had produced ~6 phantom-typo false positives in an earlier manual pass — e.g. "version 1Phase 1 limitation" for live text "Phase 1 limitation"). The text/plain export also embeds inline comments as [a]/[b]/[c] markers — discovered during the test, patched into Phase 1c.

Test plan

  • CI checks pass (none required for skill docs but checking anyway)
  • Cursor Bugbot review — no Critical findings
  • Copilot review — address any inline comments
  • tessl skill review skills/review-document/ returns ≥ 90 %
  • After merge: in a fresh Claude Code session, /devflow:review-document <google-doc-url> is discoverable and executes Phase 0 → 4 end-to-end

🤖 Generated with Claude Code

New skill: review-document — multi-perspective prose-document review
counterpart to /devflow:write-spike. Reviews KB articles, RFCs, spikes,
runbooks, PRDs, design docs hosted on Google Docs, Confluence, local
files, or arbitrary URLs. Sibling to /devflow:review (which targets
code diffs).

Skill workflow (6 phases):

* Phase 0 — source detection + CLEAN fetch (strips Google Docs
  suggestion-mode strikethrough, Confluence change-tracking spans,
  Word track-changes) + auto-picks anchor format (file:line for local,
  §heading+quote for hosted)
* Phase 1 — linked-ticket pull (Jira via Atlassian MCP) + Hindsight
  recall + existing platform comments (Confluence inline/footer with
  resolved_state; Google Docs via text/plain export embedding
  [a]/[b]/[c] markers — all RAISED-OPEN by default since the export
  format does not carry resolved_state)
* Phase 2 — parallel agents dispatched as Task subagents (with
  subagent_type per the AGENTS.md role table). Agent set per DOC_TYPE:
  KB → critic + writer + document-specialist; spike/RFC → critic +
  verifier + architect; runbook → critic + verifier +
  security-reviewer; design → critic + writer (+ visual-verdict skill
  sequentially)
* Phase 3 — severity scoring + cross-agent dedup + cross-check against
  existing comments (NEW / RAISED-OPEN / RAISED-RESOLVED-FIXED /
  RAISED-RESOLVED-NOT-FIXED — RAISED-RESOLVED-FIXED moves to Strengths
  and is never re-flagged)
* Phase 4 — visual output mirroring /devflow:review (emoji severity,
  bold key terms, ≤3 lines per finding, TL;DR)
* Phase 5 — retain learnings to Hindsight

Tessl skill review: 90% (passed create-skill ≥85% gate). Five
optimize-skill iterations all kept at plateau per Tessl-gated Ralph
loop discipline. Subagent spec-review surfaced 0 Critical findings;
4 Important findings applied inline (Task tool/subagent_type dispatch
clarity, visual-verdict-as-skill-not-subagent activation, Google Docs
resolved_state caveat).

Soft dependency on upstream defuddle CLI
(github.com/kepano/defuddle, npm install -g defuddle) for clean web
fetches on arbitrary URLs — falls back to WebFetch when missing.
Defuddle is NOT vendored into devflow; the Formula caveats and
install.sh nudge the user to install it manually.

Files:

* skills/review-document/{SKILL.md, AGENTS.md, TEMPLATES.md}
* devflow-plugin/skills/review-document/{SKILL.md, AGENTS.md, TEMPLATES.md}
  (mirror for plugin distribution)
* skills/registry.json — register new skill in code-review category
* Formula/devflow.rb — defuddle soft-dep in caveats
* install.sh — optional defuddle check at end
* README.md — skills table row added (18 → 19 slash commands),
  prerequisites note defuddle as optional
* visualizations/architecture/code-review-architecture.md — new
  section 5 with full Mermaid flow diagram for /devflow:review-document
* visualizations/architecture/devflow-ecosystem.md — commands table
  row added

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 28, 2026 19:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@AndreJorgeLopes AndreJorgeLopes merged commit 51cdf57 into main May 28, 2026
1 check failed
@AndreJorgeLopes AndreJorgeLopes deleted the feat/review-document-skill branch May 28, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants