Skip to content

fix(release): chore/docs-only ranges yield none (revert #38 patch floor) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreJorgeLopes merged 1 commit into from
Jun 15, 2026
Merged

fix(release): chore/docs-only ranges yield none (revert #38 patch floor) #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,10 @@ _parse_conventional_commits() {
done < <(git -C "$project_dir" log "$log_target" --format='%B%x00' 2>/dev/null)
IFS="$IFS_SAVE"

# Patch floor: any non-[skip release] merge that has commits cuts AT LEAST a
# patch, so docs/chore/refactor/etc. merges still release (keeps "merge =
# release"). The empty-range and [skip release] cases already returned "none".
if [[ "$bump" == "none" ]]; then
bump="patch"
fi
# No patch floor: docs/chore/refactor/test/ci/style/perf-only ranges yield
# "none" (no release), matching conventional-commit rules and the documented
# release process. Only feat/fix/breaking cut a release. To force a release for
# an otherwise-non-releasable range, dispatch release.yml with bump_override.

# Output
echo "$bump"
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/release.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ PJ
MJ
cat > "$proj/devflow-plugin/commands/test-cmd.md" <<'CMD'
---
description: "[devflow v0.1.0] Test command"
description: [0.1.0] Test command
---
CMD

Expand All @@ -177,7 +177,7 @@ CMD
assert_success
run grep '"version": "0.2.0"' "$proj/devflow-plugin/.claude-plugin/marketplace.json"
assert_success
run grep '\[devflow v0.2.0\]' "$proj/devflow-plugin/commands/test-cmd.md"
run grep '\[0.2.0\]' "$proj/devflow-plugin/commands/test-cmd.md"
assert_success
}

Expand Down