V0.2.0/spatial codecs - #33
Merged
Merged
Conversation
Introduce point cloud and Gaussian formats with streaming support, while improving native codec compatibility, error handling, documentation, and test coverage for the v0.2.0 release.
…ed-zstd's declared minimum Rust version is actually wrong. Root cause: structured-zstd calls __cpuid without an unsafe block in its x86_64 BMI2 runtime-detection path (bit_reader_reverse.rs) — I confirmed the same code is present in the latest 0.0.49, so upgrading the crate wouldn't help. __cpuid was only recently changed from an unsafe fn to a safe function in the standard library (rust-lang/stdarch#1935), and that change shipped in rustc 1.94. On rustc 1.92 — which CI now installs after the previous fix, matching the crate's advertised MSRV — __cpuid is still unsafe, so the compiler rejects the call with E0133. In other words, the crate's rust-version = "1.92" metadata understates its real requirement of 1.94. It builds fine on your Mac because the whole code path is gated to target_arch = "x86_64" and never compiles on Apple Silicon. Changes: .github/workflows/ci.yml — bumped RUST_VERSION from "1.92" to "1.94", with a comment explaining the crate's incorrect MSRV metadata. native/ex_codecs_native/Cargo.toml — bumped rust-version to "1.94" so the failure mode on an old toolchain is a clear "rustc X is not supported" message instead of a confusing E0133. README.md — updated the two "Rust 1.92+" mentions to 1.94+. cargo check passes locally (rustc 1.95.0). release.yml is unaffected since it uses latest stable. Push and CI should compile the NIF on the x86_64 runners now.
…rked @doc false: codec_registry.ex Lines 19-33 use Agent @table_name :ex_codecs_registry @registry_name __MODULE__ @doc false def child_spec(arg) do %{ id: __MODULE__, start: {__MODULE__, :start_link, [arg]} } end Because @doc false makes Code.fetch_docs/1 return :hidden (not a map), the test's is_map(doc) filter skips it. The returned spec is byte-for-byte what use Agent would have generated, so {ExCodecs.CodecRegistry, register: ...} in application.ex continues to start the registry exactly as before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.