[ACTV-451] remove 'intercom_desktop_enabled' feature flag - #1383
Merged
augdiebold merged 2 commits intoSep 17, 2026
Merged
Conversation
cjasm
approved these changes
Sep 17, 2026
augdiebold
deleted the
ACTV-451-remove-intercom-desktop-enabled-feature-flag
branch
September 17, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed changes
Remove the
intercom_desktop_enabledfeature-flag gate from Anki desktop Intercom.The launcher is no longer waiting on that remote flag. After this change it shows when the user is logged in and the Support button preference is on (
ankihub_support_button, defaulttrue).intercom_support_button_anki_preferencesis unchanged: it still controls whether the Support button checkbox appears in AnkiHub preferences.Tests that mocked or stored
intercom_desktop_enabledwere updated. Auth-app-url tests now use a generic cached flag dict so they are not tied to Intercom.How to reproduce
intercom_desktop_enabledin PostHog/feature flags.intercom_support_button_anki_preferences), turn Support button off, close preferences, and return to home: Intercom should shut down.