Repository navigation
fix(download): parse quoted and extended response filenames - #65
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
KennyMcSimpson
marked this pull request as ready for review
October 8, 2026 11:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download runner treats a response filename as a regular-expression match, which truncates quoted names such as
filename="paper;v2.pdf". It also does not handlefilename*correctly, so a server-provided Unicode filename can be lost or replaced by the fallback URL name.Use the standard email header parser for quoted parameters and RFC 2231/5987 extended filenames. Prefer the extended filename when both forms are present, and leave literal percent sequences in ordinary
filenamevalues intact. The result still goes through the existing basename sanitization.Validation:
pytest tests/test_download_filenames.py -q: 20 passed, covering quoted punctuation, extended filenames, parameter order, URL fallback, explicit-name precedence, and encoded path separators.www.iana.org. That test and its fetch implementation are unchanged.