Skip to content

Optional use own rounded BarRenderer 4.x #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hannesa2 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Optional use own rounded BarRenderer 4.x #603

hannesa2 wants to merge 6 commits into from

Conversation

@hannesa2
Copy link
Collaborator

@hannesa2 hannesa2 commented Dec 28, 2025

No description provided.

@hannesa2 hannesa2 changed the title Optional use rounded BarRenderer Optional use own rounded BarRenderer Dec 28, 2025
@hannesa2 hannesa2 changed the title Optional use own rounded BarRenderer Optional use own rounded BarRenderer 4 Dec 28, 2025
@hannesa2 hannesa2 changed the title Optional use own rounded BarRenderer 4 Optional use own rounded BarRenderer 4.x Dec 28, 2025
@hannesa2 hannesa2 force-pushed the UseRoundedRenderer branch 2 times, most recently from 191bea6 to d205e8e Compare December 28, 2025 12:49
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Dec 28, 2025

Screenshot differs: emulatorApi=9 with 21 screenshot(s)

setpoint|diff|actual screenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-11ToggleFilled.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-12ToggleCircles.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-7-PerformanceLineChart-Performance-1SampleClick.pngscreenshot

hannesa2
hannesa2 commented Dec 28, 2025
View reviewed changes
chartLib/src/main/kotlin/info/appdev/charting/renderer/RoundedBarChartRenderer.kt

if (dataProvider.isDrawBarShadowEnabled) {
// if (dataProvider.isDrawBarShadowEnabled) {
if (true) {
Copy link
Collaborator Author

@hannesa2 hannesa2 Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only enabled the rendering @Paget96

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Dec 28, 2025

@Paget96
The thing is, that it wasn't used any where, so I add a usage for this RoundedBarChartRenderer.kt
I rebased on master, and now I can compare it with screenshots, but the result doesn't convince me.
I made the same on version 3.x as well, but there is the same poor outcome.

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Dec 28, 2025

Screenshot differs: emulatorApi=9 with 16 screenshot(s)

setpoint|diff|actual screenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

@hannesa2 hannesa2 force-pushed the master branch 4 times, most recently from 159d22d to 7dc3b14 Compare December 29, 2025 12:14
@hannesa2
Optional use rounded BarRenderer
e1d848a
@hannesa2
Add rounded sample, currently with normal renderer
dce9ebb
@hannesa2
Adapt new screenshots
e42169c
@hannesa2
Now with own rounded renderer
91de88a
@hannesa2
Attempt to fix renderer
854ff7a
@hannesa2
Update RoundedBarChartRenderer
0c27558 
Added: Auto Full Radius Mode
Introduced a new setUseAutoFullRadius(true) function that enables automatic calculation of full corner radius for bars.

When enabled, the radius dynamically adapts based on the bar’s current screen width and height, ensuring fully rounded corners regardless of zoom level or chart scale.

This feature improves visual consistency, especially when zooming in/out, as the rounding remains proportional to each bar’s dimensions.

Fixed: Marker Not Showing on Highlight
Previously, markers were not appearing when bars were highlighted due to missing positional metadata.

This has been resolved by ensuring setHighlightDrawPos(...) is called inside drawHighlighted(), which correctly updates the Highlight object with the marker's draw position.

Now, the custom and other markers will be properly displayed above highlighted bars, even when using this renderer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannesa2