Conversation
fix make test failed on test-xdg-basedir Log:
Fix test failed on test_libappimage Log:
azubieta
left a comment
There was a problem hiding this comment.
I'm not sure we need to un-set the environment variable when they will be override in the next line.
In the thumbnail generation you are just ignoring the error, that's not a fix.
| g_free(sum); | ||
|
|
||
| ASSERT_TRUE(g_file_test(path.c_str(), G_FILE_TEST_EXISTS)); | ||
| ASSERT_FALSE(g_file_test(path.c_str(), G_FILE_TEST_EXISTS)); |
There was a problem hiding this comment.
The idea here is to ensure that the file is created, if this test fails there may be an error somewhere because the icon wasn't created were it is expected.
There was a problem hiding this comment.
I understand of this test case was incorrect , I will retry to fix this failed.
| g_free(sum); | ||
|
|
||
| ASSERT_TRUE(g_file_test(path.c_str(), G_FILE_TEST_EXISTS)); | ||
| ASSERT_FALSE(g_file_test(path.c_str(), G_FILE_TEST_EXISTS)); |
There was a problem hiding this comment.
The idea here is to ensure that the file is created, if this test fails there may be an error somewhere because the icon wasn't created were it is expected.
| char* oldValue = getenv("XDG_CACHE_HOME"); | ||
| char* oldValue = NULL; | ||
|
|
||
| if ((oldValue = getenv("XDG_CACHE_HOME")) != NULL) { |
There was a problem hiding this comment.
I don't think that we need to unset the environment if we are overriding it in the next line.
| char* oldValue = getenv("XDG_CONFIG_HOME"); | ||
| char* oldValue = NULL; | ||
|
|
||
| if ((oldValue = getenv("XDG_CONFIG_HOME")) != NULL) { |
There was a problem hiding this comment.
I don't think that we need to unset the environment if we are overriding it in the next line.
| char* oldValue = getenv("XDG_DATA_HOME"); | ||
| char* oldValue = NULL; | ||
|
|
||
| if ((oldValue = getenv("XDG_DATA_HOME")) != NULL) { |
There was a problem hiding this comment.
I don't think that we need to unset the environment if we are overriding it in the next line.
Fix make test failed