Fix how we get latest in s3 buckets

[louiscb]

We thought to spread out the changes of my original pr into several.

This will use the is_latest tag, and also passes in the prefix so that we only lookup the correct object instead of listing all objects in the whole bucket.

I tested and can see the even buckets that are not versioned will return is_latest for an object. e.g for appmonet.com bucket :

contents #=> [
  %{
    owner: %{
      id: "a59edb577d3ca9ca18794e866cc0c131d4bb9232f58dc8be4c4d634f9ff784dc",
      display_name: "nick.jacob"
    },
    size: "17100",
    key: "index.html",
    last_modified: "2017-04-01T14:20:53.000Z",
    etag: "\"adf6d5ab13452ec30d7556caaf49fab8\"",
    version_id: "null",
    is_latest: "true"
  }
]

[sneako]

Suggested change

dbg contents

[sneako]

Are you matching on this :not_found somewhere? Otherwise I think we should either:

• use a more descriptive string, something like "object @ #{key} was not found"
• introduce an Exception that will produce a similar message to the string above

[louiscb]

yes we match on it already when we call find_latest:

      {:error, :not_found} ->
        {:error, "could not find s3://#{state.bucket}/#{state.key}"}

[sneako]

perfect

[sneako]

can you please just increment the patch version? then we can merge and publish this

[louiscb]

oh yea ofc!