Introduce deep-copy utilities#429
Merged
christian-rauch merged 1 commit intoAprilRobotics:masterfrom Mar 6, 2026
Merged
Conversation
fspindle
added a commit
to fspindle/visp
that referenced
this pull request
Mar 5, 2026
Improve my_apriltag_detector_copy() followin discussion on PR lagadic#429 AprilRobotics/apriltag#429
- Add apriltag_detection_copy() and apriltag_detections_copy() to deep copy detection results including the matd_t* H homography matrix. - Add apriltag_detector_copy() to clone detector configuration by copying all scalar fields and reinitializing pointer fields (tag_families, tp, wp) to independent default values to avoid shared ownership and double-free issues on destruction.
fspindle
force-pushed
the
deep_copy_utilities
branch
from
150d2e3 to
57918a2
Compare
christian-rauch
approved these changes
Mar 6, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functions to simplify memory management when detections need to be passed between threads or stored beyond the detector's lifecycle.
This PR follows recommendation given in PR #428