Skip to content

Feature/ih 1382#133

Closed
sjohn-Hach wants to merge 4 commits into
mainfrom
feature/IH-1382
Closed

Feature/ih 1382#133
sjohn-Hach wants to merge 4 commits into
mainfrom
feature/IH-1382

Conversation

@sjohn-Hach

@sjohn-Hach sjohn-Hach commented Jun 3, 2026

Copy link
Copy Markdown

No description provided.

@sjohn-Hach sjohn-Hach requested a review from a team June 3, 2026 07:27
@sjohn-Hach sjohn-Hach mentioned this pull request Jun 3, 2026
Merged
surajndhach
surajndhach previously approved these changes Jun 4, 2026
View reviewed changes
rsingh-hach
rsingh-hach previously approved these changes Jun 5, 2026
View reviewed changes
MatthewDeRose-AI
MatthewDeRose-AI requested changes Jun 5, 2026
View reviewed changes

@MatthewDeRose-AI MatthewDeRose-AI left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the ProtocolBuffer submodule changes here. Without those the changes you have in protocol buffers won't appear in the published Nuget Pacakge version. You can use this PR as a reference https://github.com/AquaticInformatics/ONE.Interfaces.CSharp/pull/130/changes

@sjohn-Hach sjohn-Hach dismissed stale reviews from rsingh-hach and surajndhach via 4c63650 June 8, 2026 16:05
@sjohn-Hach

sjohn-Hach commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

I'm not seeing the ProtocolBuffer submodule changes here. Without those the changes you have in protocol buffers won't appear in the published Nuget Pacakge version. You can use this PR as a reference https://github.com/AquaticInformatics/ONE.Interfaces.CSharp/pull/130/changes

I have updated the submodule. Could you please review it again?

AQI-DanG
AQI-DanG reviewed Jun 11, 2026
View reviewed changes
Comment thread src/ONE.Models.CSharp/ONE.Models.CSharp.csproj
<!--For Release packages update
the VersionPrefix and remove any VersionSuffix-->
<VersionPrefix>7.24.0</VersionPrefix>
<VersionPrefix>7.25.0</VersionPrefix>

@AQI-DanG AQI-DanG Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @mathitharmalingam-aqi may be using this version already

@AQI-DanG

AQI-DanG commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

These changes have been published as part of v7.25 along with @mathitharmalingam-aqi 's changes.

@AQI-DanG AQI-DanG closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AQI-DanG AQI-DanG AQI-DanG left review comments
@MatthewDeRose-AI MatthewDeRose-AI MatthewDeRose-AI left review comments
@MartinBenn-AI MartinBenn-AI Awaiting requested review from MartinBenn-AI
@nitinpalewar-hach nitinpalewar-hach Awaiting requested review from nitinpalewar-hach
@rjoshi-hach rjoshi-hach Awaiting requested review from rjoshi-hach
@skumar-hach skumar-hach Awaiting requested review from skumar-hach
@Abhijeet-2890 Abhijeet-2890 Awaiting requested review from Abhijeet-2890
@vkunuguntl vkunuguntl Awaiting requested review from vkunuguntl
@surajndhach surajndhach Awaiting requested review from surajndhach
@rsingh-hach rsingh-hach Awaiting requested review from rsingh-hach

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sjohn-Hach @AQI-DanG @MatthewDeRose-AI @surajndhach @rsingh-hach