docs(archdev-skill): seal a PR's source groups instead of its focus ranges - #46
Draft
rafael-archastro wants to merge 2 commits into
Draft
rafael-archastro wants to merge 2 commits into
rafael-archastro wants to merge 2 commits into
Conversation
added 2 commits
October 1, 2026 09:48
…anges The code-region step now seals the groups archdev inspect regions prints, the same units archdev publish seals, so a session and the Factory agree on what a hunk's seal is: one group per semantic-group label over source hunks, one per file for the rest. A group whose content digest the previous head already sealed reuses that judgment with --carried-from; at most six groups are judged fresh per push. The bootstrap probes inspect regions and extract finalize --region, which the release carrying firstlanding #16218 and #16143 provides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and author intent
Issue ArchAstro/firstlanding#14994, task 6 second half, PR 4 of 4. Since firstlanding #16222
archdev publishseals onerisk.code-regionassessment per source group of every head it pushes, carrying a group's seal forward when its content did not change. The skill still seals a PR's focus ranges, which the annotator's own risk label picks, so a session and the Factory seal different ranges of the same head, and a session's seals never carry forward.This PR moves the skill's code-region step onto the same units.
What changed
archdev/references/monitor.md: "Focus range seals" becomes "Source group seals". The step lists the head's groups witharchdev inspect regions <pull>(one per semantic-group label over source hunks, one per file for the rest; test, docs, lockfile and generated paths never form a group), reuses the previous head's seal for a group whosecontent_sha256it already sealed (--carried-from <head>:<digest>, judged fresh if finalize refuses the carry), collects each group from its printedlocations, seals with--region <printed value>, judges at most six groups fresh per push, and verifies that every printed group has a seal whoseregion.content_sha256matches. Cross-references in the risk-assessment and annotation sections follow.archdev/SKILL.md: the requirement line and the monitor beat name the new commands and units.archdev/scripts/bootstrap.sh/.ps1: probeinspect regions --helpandextract finalize --helpfor--region, with the update messages naming them.archdev/references/bootstrap.mdlists the probes.scripts/fake-archdevanswers them.Unchanged:
min_version(0.47.0) and every other probe; the Tasks skill.Merge gate
The probed commands ship with firstlanding #16143 (
--region,--carried-from) and #16218 (inspect regions); the latest release at the time of writing (v0.48.1) predates both. On an older CLI the bootstrap would try to update and then stop, so this PR must not merge before a release carries them. Bumpmin_versionto that release in the same merge if a floor is wanted.Testing
scripts/test-skill-bootstrap.sh: 24 cases pass (run withTMPDIR=/private/tmpon macOS, where/varis a symlink the bootstrap resolves and the test does not; CI runs on Linux).