feat(closures): captures are no longer fully qualified#568
Merged
Conversation
This means that we can safely capture top-level variables in packages, without having to write closure.pkg:var later on. Internally, variables are still fully qualified, but a rename instruction has been added for captures, and unqualified names are tracked in the AST for this to work.
Static analysis reportLizard reportListing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.
Report about files you didn't modify in this PR
CppCheck report
Report files about files you didn't modify in this PR
|
CodSpeed Performance ReportMerging #568 will degrade performances by 2.22%Comparing Summary
Benchmarks breakdown
|
Fuzzing report/usr/local/bin/afl-whatsup status check tool for afl-fuzz by Michal Zalewski Summary statsCycles without finds : 0 [+] Captured 47124 tuples (map size 220195, highest value 255, total values 388319515) in '/dev/null'. |
e3b7344 to
fe09671
Compare
…ons, because it put its mapping at the end of the global scope This resulted either in data from scope 1+ being overwritten, or invalid indices for LOAD_SYMBOL_BY_INDEX, as we added one or more locals between the local we wanted to load and the last module's local.
fe09671 to
1034dc7
Compare
…separate file to avoid code duplication and circular includes
389a67a to
c83e259
Compare
c83e259 to
d1e05ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This means that we can safely capture top-level variables in packages, without having to write
closure.pkg:varlater on. Internally, variables are still fully qualified, but a rename instruction has been added for captures, and unqualified names are tracked in the AST for this to work.Checklist