feat(app): restore Settings "Check for Updates" button; solid dark-gray overlay pill#74
Merged
Conversation
…pill a solid dark-gray capsule Two changes: Settings — re-add the "Check for Updates" button to the Advanced pane (dropped in dc6bff0). An "Updates" section shows the running version and a button that runs the shared UpdateCheckModel and reports the result in a modal — the same check reachable from the app menu / menu-bar item, all sharing the one controller. Restores UpdateCheckModel.currentVersionText and the settings.update.check UITest identifier. Under UI testing the check is stubbed offline (UITestUpdateTransport + UpdateCheckModel.uiTest()) to always report up-to-date, so the new testCheckForUpdatesShowsResultAlert exercises the button → result-sheet flow deterministically without reaching GitHub. Overlay — replace the pill's Liquid Glass body with a solid, opaque dark-gray capsule. `.glassEffect(.regular.tint:)` is an adaptive material that samples the backdrop to pick its light/dark rendering, and can't do so until composited on screen; fading in from alpha 0 it flashed white for a frame over a dark desktop before settling. A fixed fill never adapts, so the pill fades in the same dark gray on any backdrop. Every state is the same dark gray except .error, which keeps a red body as an alarm cue. Drops the now-unused glassCapsuleCompat helper (Liquid Glass stays for the prominent buttons via glassButtonStyleCompat). Verified: scripts/check.sh green; testCheckForUpdatesShowsResultAlert and testOverlayPillTracksDictation pass; dev build runs clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings — restore "Check for Updates"
Re-adds the Check for Updates button to the Advanced pane (dropped in dc6bff0). An "Updates" section shows the running version and a button that runs the shared
UpdateCheckModeland reports the result in a modal — the same check reachable from the app menu and menu-bar item, all sharing the one controller. RestoresUpdateCheckModel.currentVersionTextand thesettings.update.checkUITest identifier.Under UI testing the check is stubbed offline (
UITestUpdateTransport+UpdateCheckModel.uiTest()) to always report up-to-date, so the newtestCheckForUpdatesShowsResultAlertexercises the button → result-sheet flow deterministically without reaching GitHub.Overlay — solid dark-gray pill (no Liquid Glass)
The pill body was
.glassEffect(.regular.tint:)— an adaptive material that samples the backdrop to pick its light/dark rendering, and can't do so until it's composited on screen. Fading in fromalpha 0, it flashed white for a frame over a dark desktop before settling dark; over a light desktop the light default ≈ the settled light, so it looked stable — the asymmetry that surfaced the bug.Replaced it with a solid, opaque dark-gray capsule. A fixed fill never adapts, so the pill fades in the same dark gray on any backdrop with no flash. Every state is the same dark gray except
.error, which keeps a red body as an alarm cue.Drops the now-unused
glassCapsuleCompathelper. Liquid Glass stays for the prominent buttons (glassButtonStyleCompat) — those never had the flash problem and using glass there is the native macOS 26 idiom.Verification
scripts/check.shgreen (exit 0).testCheckForUpdatesShowsResultAlertandtestOverlayPillTracksDictationpass.🤖 Generated with Claude Code