Skip to content

feat(app): restore Settings "Check for Updates" button; solid dark-gray overlay pill#74

Merged
alexkroman merged 1 commit into
mainfrom
feat/settings-update-button-and-pill-appearance
Jul 8, 2026
Merged

feat(app): restore Settings "Check for Updates" button; solid dark-gray overlay pill#74
alexkroman merged 1 commit into
mainfrom
feat/settings-update-button-and-pill-appearance

Conversation

@alexkroman

Copy link
Copy Markdown
Collaborator

Settings — restore "Check for Updates"

Re-adds the Check for Updates button to the Advanced pane (dropped in dc6bff0). An "Updates" section shows the running version and a button that runs the shared UpdateCheckModel and reports the result in a modal — the same check reachable from the app menu and menu-bar item, all sharing the one controller. Restores UpdateCheckModel.currentVersionText and the settings.update.check UITest identifier.

Under UI testing the check is stubbed offline (UITestUpdateTransport + UpdateCheckModel.uiTest()) to always report up-to-date, so the new testCheckForUpdatesShowsResultAlert exercises the button → result-sheet flow deterministically without reaching GitHub.

Overlay — solid dark-gray pill (no Liquid Glass)

The pill body was .glassEffect(.regular.tint:) — an adaptive material that samples the backdrop to pick its light/dark rendering, and can't do so until it's composited on screen. Fading in from alpha 0, it flashed white for a frame over a dark desktop before settling dark; over a light desktop the light default ≈ the settled light, so it looked stable — the asymmetry that surfaced the bug.

Replaced it with a solid, opaque dark-gray capsule. A fixed fill never adapts, so the pill fades in the same dark gray on any backdrop with no flash. Every state is the same dark gray except .error, which keeps a red body as an alarm cue.

Drops the now-unused glassCapsuleCompat helper. Liquid Glass stays for the prominent buttons (glassButtonStyleCompat) — those never had the flash problem and using glass there is the native macOS 26 idiom.

Verification

  • scripts/check.sh green (exit 0).
  • testCheckForUpdatesShowsResultAlert and testOverlayPillTracksDictation pass.
  • Dev build runs clean.
  • The pill is now a settled state (not a transient flash), so it's easy to eyeball: run a dictation and the pill is a consistent dark gray on any background, red on error.

🤖 Generated with Claude Code

…pill a solid dark-gray capsule

Two changes:

Settings — re-add the "Check for Updates" button to the Advanced pane
(dropped in dc6bff0). An "Updates" section shows the running version and a
button that runs the shared UpdateCheckModel and reports the result in a
modal — the same check reachable from the app menu / menu-bar item, all
sharing the one controller. Restores UpdateCheckModel.currentVersionText and
the settings.update.check UITest identifier.

Under UI testing the check is stubbed offline (UITestUpdateTransport +
UpdateCheckModel.uiTest()) to always report up-to-date, so the new
testCheckForUpdatesShowsResultAlert exercises the button → result-sheet flow
deterministically without reaching GitHub.

Overlay — replace the pill's Liquid Glass body with a solid, opaque dark-gray
capsule. `.glassEffect(.regular.tint:)` is an adaptive material that samples the
backdrop to pick its light/dark rendering, and can't do so until composited on
screen; fading in from alpha 0 it flashed white for a frame over a dark desktop
before settling. A fixed fill never adapts, so the pill fades in the same dark
gray on any backdrop. Every state is the same dark gray except .error, which
keeps a red body as an alarm cue. Drops the now-unused glassCapsuleCompat helper
(Liquid Glass stays for the prominent buttons via glassButtonStyleCompat).

Verified: scripts/check.sh green; testCheckForUpdatesShowsResultAlert and
testOverlayPillTracksDictation pass; dev build runs clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@alexkroman alexkroman added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 2044bd8 Jul 8, 2026
6 checks passed
@alexkroman alexkroman deleted the feat/settings-update-button-and-pill-appearance branch July 8, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants