Skip to content

Floating windows now appear in front#287

Merged
rhit-FANA merged 2 commits intomainfrom
fix-release-issues
Feb 4, 2026
Merged

Floating windows now appear in front#287
rhit-FANA merged 2 commits intomainfrom
fix-release-issues

Conversation

@rhit-FANA
Copy link
Contributor

was a 1 line fix

Copy link
Contributor

@rhit-maroisem rhit-maroisem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rhit-steineig rhit-steineig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When #273 was merged, #276 was created, but so were other bugs like windows not closing when the escape key is pressed, or being focused correctly. To fix all of these bugs while also making sure not to re-introduce the http 500 code errors that #273 fixed, make it so your only change is deleting the line if (browser) return;

Copy link
Contributor

@rhit-steineig rhit-steineig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhit-FANA rhit-FANA merged commit f10dfd6 into main Feb 4, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Unrefined to Done in Current Tasks Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Newly opened floating windows are not positioned in front of other windows

3 participants