feat (mobile): Update template picker to use ComboBox#289
Open
1FoxInTheBox1 wants to merge 3 commits intomainfrom
Open
feat (mobile): Update template picker to use ComboBox#2891FoxInTheBox1 wants to merge 3 commits intomainfrom
1FoxInTheBox1 wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #277 replaced the template picker with a ComboBox from SkeletonUI. This change only happened on the desktop version.
This moves a lot of the template loading and selecting logic to the shared CreateItem component, then updates CreateItemMobile to use a ComboBox as well.
Also, seems like a lot of whitespace changes got bunched in here after a
npm run lint:fix. Sorry about that.