Use optimal inverse transform for rectification#961
Draft
oczoske wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
- Coverage 75.60% 75.45% -0.15%
==========================================
Files 70 70
Lines 8981 9001 +20
==========================================
+ Hits 6790 6792 +2
- Misses 2191 2209 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #959 , this PR implements a least-squares fit for the transformation used in rectifying spectra. This avoids the systematics caused by the interpolated inverse matrix transforms for METIS LMS. The matrix transforms can be used by setting
opttrain.rectify_cube(hdul, fit_inverse=False)It still needs to be ensured that the PR also works for
rectify_traces(), used for long-slit spectroscopy in METIS and MICADO.