Repository navigation
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
I have actually gotten issues filed to I think this still handles that case though. |
| local backend = "smart-splits-backend-ghostty" | ||
| return { | ||
| "smart-splits-nvim/smart-splits.nvim", | ||
| opts = function(_, opts) |
There was a problem hiding this comment.
I'm not super familiar with the conventions of this repo yet so idk where exactly it would go but it might be worth extracting this to a shared helper function somewhere
There was a problem hiding this comment.
yeah we do have a small "utility" file for AstroCommunity but it has focused on some pretty general things that is useful for any and all plugin specs. Not sure if we want to expand it to being for more specific stuff. Not sure what the best pattern is here honestly
There was a problem hiding this comment.
Maybe something like lua/astrocommunity/split-and-window/utils.lua or something? it's a little tricky since smart-splits.nvim itself is in core, so we don't have a natural place here like lua/astrocommunity/split-and-window/smart-splits/utils.lua which is what I would otherwise recommend.
a32f976 to
b3f6768
Compare
Oh yeah, this is the main case I'm thinking about. I am not really considering kitty as a true "terminal multiplexer" it just has similar features like ghostty. I would expect people in a terminal session to really use at maximum 1 terminal multiplexer application (zellij/tmux) and 1 terminal emulator (ghostty/kitty) and we should prefer the true multiplexers over the terminal emulator |
b3f6768 to
5d95c6c
Compare
5d95c6c to
90878eb
Compare
|
FYI there’s been a community backend for Herdr that popped up if you wanna include that one https://github.com/smart-splits-nvim/smart-splits.nvim#community-backends |
|
Oh lmao you beat me to it |
📑 Description
AstroNvim v7 is going to be moving to smart-splits v3 which separates out the various supported backends. With this we are going to be making them optional to the user so they can opt into whichever backends they want on their system. This does a first pass at adding these in with the proper logic to handle however the user may end up having them setup. We can leave this as a draft until the v7 release is made
This basically takes the pattern of:
Naturally people won't be using more than one terminal emulator at one time, practically people shouldn't be in nested terminal multiplexers so I think this out of the box behavior of how the priority list would be built if they added all of them should be solid.
Depends on:
📖 Additional Information