Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
Accelerator
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
AtCoder-NoviSteps
/
AtCoderNoviSteps
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
10
Star
67
Code
Issues
75
Pull requests
1
Actions
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Security and quality
Insights
fix: implement CodeRabbit findings (#3364)
- #3371
#3371
Merged
KATO-Hiro
merged 47 commits into
staging
AtCoder-NoviSteps/AtCoderNoviSteps:staging
from
#3364
AtCoder-NoviSteps/AtCoderNoviSteps:#3364
Copy head branch name to clipboard
Apr 9, 2026
Conversation
Commits
47
(47)
Checks
Files changed
Merged
fix: implement CodeRabbit findings (#3364)
#3371
KATO-Hiro
merged 47 commits into
staging
AtCoder-NoviSteps/AtCoderNoviSteps:staging
from
#3364
AtCoder-NoviSteps/AtCoderNoviSteps:#3364
Copy head branch name to clipboard
Commits
Commits on Apr 6, 2026
docs: Add plan and review for PR #3316 post-merge fixes
Show description for 08c2adf
KATO-Hiro
and
claude
committed
08c2adf
View commit details
Copy full SHA for 08c2adf
Browse repository at this point
test: migrate process.env manual stubs to vi.stubEnv in atcoder_verification tests
KATO-Hiro
committed
2687ff0
View commit details
Copy full SHA for 2687ff0
Browse repository at this point
test: add unit tests for getUser, getUserById, and deleteUser
KATO-Hiro
committed
e50bb41
View commit details
Copy full SHA for e50bb41
Browse repository at this point
refactor: extract MIN_VOTES_FOR_STATISTICS to client-safe constant and remove hardcoded '3' in votes page
KATO-Hiro
committed
00cbd6c
View commit details
Copy full SHA for 00cbd6c
Browse repository at this point
docs: update plan - use internal_clients/vote_grade.ts instead of services/vote_api.ts (non-service layer clarification)
KATO-Hiro
committed
c5b497a
View commit details
Copy full SHA for c5b497a
Browse repository at this point
refactor: add return value to upsertVoteGradeTables and use it in vote_actions
KATO-Hiro
committed
e117eb5
View commit details
Copy full SHA for e117eb5
Browse repository at this point
fix: handle RecordNotFound error in setTaskGrade action for vote_management
KATO-Hiro
committed
9d4ec03
View commit details
Copy full SHA for 9d4ec03
Browse repository at this point
feat: add loading state to SubmissionButton via FormWrapper context (prevent double-submit)
KATO-Hiro
committed
b12edec
View commit details
Copy full SHA for b12edec
Browse repository at this point
feat: add button gap and replace custom clipboard with Flowbite Clipboard in AtCoderVerificationForm
KATO-Hiro
committed
a24be95
View commit details
Copy full SHA for a24be95
Browse repository at this point
fix: ensure isSubmitting is reset even when form update throws exception
KATO-Hiro
committed
256bf34
View commit details
Copy full SHA for 256bf34
Browse repository at this point
docs: fix comment wording and remove redundant type assertion
KATO-Hiro
committed
c107ebf
View commit details
Copy full SHA for c107ebf
Browse repository at this point
feat: create vote_grade internal client with fetchMyVote, submitVote, fetchMedianVote
KATO-Hiro
committed
5b23fe1
View commit details
Copy full SHA for 5b23fe1
Browse repository at this point
refactor: use vote_grade.ts in VotableGrade and add AbortController for rapid-click protection
KATO-Hiro
committed
65a6bef
View commit details
Copy full SHA for 65a6bef
Browse repository at this point
fix: update E2E test selectors and add initial state check for votes page
KATO-Hiro
committed
696e6c0
View commit details
Copy full SHA for 696e6c0
Browse repository at this point
feat: add CHECK constraints for vote grade models (count >= 0, grade != PENDING)
KATO-Hiro
committed
e037ab5
View commit details
Copy full SHA for e037ab5
Browse repository at this point
docs: add new coding rules derived from PR #3316 review (SSR, FK, auth, env stubs)
KATO-Hiro
committed
2a4aecf
View commit details
Copy full SHA for 2a4aecf
Browse repository at this point
fix: address CodeRabbit findings - remove misleading test and fix FormData inconsistency
KATO-Hiro
committed
70a0767
View commit details
Copy full SHA for 70a0767
Browse repository at this point
Merge branch 'staging' of github.com:AtCoder-NoviSteps/AtCoderNoviSteps into #3364
KATO-Hiro
committed
6a541e4
View commit details
Copy full SHA for 6a541e4
Browse repository at this point
Commits on Apr 8, 2026
refactor: rename PrismaUserWithAccount to UserWithAtCoderAccount to remove ORM-specific naming
KATO-Hiro
committed
0fc88a1
View commit details
Copy full SHA for 0fc88a1
Browse repository at this point
refactor: use UUID format for SAMPLE_USER_ID and document Lucia dependency
KATO-Hiro
committed
0e124b8
View commit details
Copy full SHA for 0e124b8
Browse repository at this point
fix: use Roles.USER enum instead of string literal in test fixtures
KATO-Hiro
committed
bc139d8
View commit details
Copy full SHA for bc139d8
Browse repository at this point
refactor: extract mock helpers and use Partial types to avoid any/never casts
KATO-Hiro
committed
89b22c4
View commit details
Copy full SHA for 89b22c4
Browse repository at this point
test: add error case for generate function and organize describe blocks by scenario
KATO-Hiro
committed
5b2023f
View commit details
Copy full SHA for 5b2023f
Browse repository at this point
refactor: extract mockFindUniqueOrThrowError helper to avoid mock setup duplication
KATO-Hiro
committed
d64ef41
View commit details
Copy full SHA for d64ef41
Browse repository at this point
test: organize validate describe block by scenario
Show description for 5682ed2
KATO-Hiro
and
claude
committed
5682ed2
View commit details
Copy full SHA for 5682ed2
Browse repository at this point
test: reorganize validate describe blocks by 正常系/異常系
Show description for f879ce4
KATO-Hiro
and
claude
committed
f879ce4
View commit details
Copy full SHA for f879ce4
Browse repository at this point
test: split abnormal cases by return value (false vs throws)
Show description for 1ff1e19
KATO-Hiro
and
claude
committed
1ff1e19
View commit details
Copy full SHA for 1ff1e19
Browse repository at this point
test: organize reset describe block and add error case
Show description for 2d8a702
KATO-Hiro
and
claude
committed
2d8a702
View commit details
Copy full SHA for 2d8a702
Browse repository at this point
docs: formalize internal_clients and test organization patterns
Show description for da0eddf
KATO-Hiro
and
claude
committed
da0eddf
View commit details
Copy full SHA for da0eddf
Browse repository at this point
test: reorganize users.test.ts with fixtures and organize describe blocks
Show description for c205d2f
KATO-Hiro
and
claude
committed
c205d2f
View commit details
Copy full SHA for c205d2f
Browse repository at this point
refactor: translate SubmissionButton comment to English
Show description for 3355d24
KATO-Hiro
and
claude
committed
3355d24
View commit details
Copy full SHA for 3355d24
Browse repository at this point
feat: add color prop to SubmissionButton and improve ButtonColor type extraction
Show description for ef1977c
KATO-Hiro
and
claude
committed
ef1977c
View commit details
Copy full SHA for ef1977c
Browse repository at this point
test: refactor vote_grade.test.ts with HTTP mock helpers and parametrized tests
Show description for 68ca9c0
KATO-Hiro
and
claude
committed
68ca9c0
View commit details
Copy full SHA for 68ca9c0
Browse repository at this point
refactor: move getBaseUrl helper after exported functions in vote_grade.ts
Show description for 609addf
KATO-Hiro
and
claude
committed
609addf
View commit details
Copy full SHA for 609addf
Browse repository at this point
chore: fix order
KATO-Hiro
committed
556822e
View commit details
Copy full SHA for 556822e
Browse repository at this point
docs: clean up completed plan.md for PR #3316 review
Show description for 2a5cd61
KATO-Hiro
and
claude
committed
2a5cd61
View commit details
Copy full SHA for 2a5cd61
Browse repository at this point
docs: update Task 10 plan for votes E2E test fix
Show description for e9dfab8
KATO-Hiro
and
claude
committed
e9dfab8
View commit details
Copy full SHA for e9dfab8
Browse repository at this point
fix: repair vote detail E2E tests broken by search-first UI and stale selectors
Show description for 40a4818
KATO-Hiro
and
claude
committed
40a4818
View commit details
Copy full SHA for 40a4818
Browse repository at this point
docs(rules): add E2E lessons from votes test fix
Show description for ab4d948
KATO-Hiro
and
claude
committed
ab4d948
View commit details
Copy full SHA for ab4d948
Browse repository at this point
style: fix formatting in testing-e2e.md
Show description for e135750
KATO-Hiro
and
claude
committed
e135750
View commit details
Copy full SHA for e135750
Browse repository at this point
docs: add CodeRabbit findings to plan.md
Show description for 222d409
KATO-Hiro
and
claude
committed
222d409
View commit details
Copy full SHA for 222d409
Browse repository at this point
docs: add implementation plan for CodeRabbit findings
Show description for 62e9fa1
KATO-Hiro
and
claude
committed
62e9fa1
View commit details
Copy full SHA for 62e9fa1
Browse repository at this point
docs(rules): consolidate and streamline coding standards
Show description for 2d3494f
KATO-Hiro
and
claude
committed
2d3494f
View commit details
Copy full SHA for 2d3494f
Browse repository at this point
Commits on Apr 9, 2026
fix: implement CodeRabbit findings #1-10 (Phase 1-4)
Show description for fb4d1a6
KATO-Hiro
and
claude
committed
fb4d1a6
View commit details
Copy full SHA for fb4d1a6
Browse repository at this point
docs: remove completed PR #3316 review notes
Show description for 4f16134
KATO-Hiro
and
claude
committed
4f16134
View commit details
Copy full SHA for 4f16134
Browse repository at this point
fix: implement CodeRabbit findings (Phase 2)
Show description for 1f1ab4b
KATO-Hiro
and
claude
committed
1f1ab4b
View commit details
Copy full SHA for 1f1ab4b
Browse repository at this point
fix(migration): fix failed vote grade CHECK constraint migration in staging
Show description for bae4e80
KATO-Hiro
and
claude
committed
bae4e80
View commit details
Copy full SHA for bae4e80
Browse repository at this point
You can’t perform that action at this time.
