Skip to content

feature/sem-entities-path-based#88

Open
MattCozendey wants to merge 1 commit intoAtaraxy-Labs:mainfrom
MattCozendey:feature/sem-entities-no-path
Open

feature/sem-entities-path-based#88
MattCozendey wants to merge 1 commit intoAtaraxy-Labs:mainfrom
MattCozendey:feature/sem-entities-no-path

Conversation

@MattCozendey
Copy link
Copy Markdown
Contributor

@MattCozendey MattCozendey commented Apr 17, 2026

sem entities now works via path, instead of being scoped to single files. this allows for repo-wide entity search across multiple files at once. The old calling shape remains the same, because "sem entities ./foo.ts" is, after all, also a path. By default, "sem entities" list all entities.

If only one file is found, no grouping happens.

…les. this allows for repo-wide entity search across multiple files at once.
Copy link
Copy Markdown

@inspect-review inspect-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 20 entities analyzed | 0 critical, 0 high, 9 medium, 11 low
Verdict: standard_review

Findings (2)

  1. [low] MCP tool API breaking change: EntitiesParams renamed from required file_path: String to optional path: Option<String>, so existing callers sending file_path will fail to deserialize (missing field) and break at runtime. Evidence: crates/sem-mcp/src/tools.rs changed to pub path: Option<String> and sem_entities now reads params.path.
  2. [low] MCP directory mode silently skips unreadable/non-UTF8 files by ignoring read_to_string errors, returning partial/incomplete entity lists without signaling failure. Evidence: crates/sem-mcp/src/server.rs directory branch: if let Ok(content) = std::fs::read_to_string(&abs_path) { all_entities.extend(...) } (no else/error).

Reviewed by inspect | Entity-level triage found 0 high-risk changes

@MattCozendey
Copy link
Copy Markdown
Contributor Author

these risks are fair @rs545837 do you like the general direction of this PR? Should I fix those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant