feature/sem-entities-path-based#88
Open
MattCozendey wants to merge 1 commit intoAtaraxy-Labs:mainfrom
Open
Conversation
…les. this allows for repo-wide entity search across multiple files at once.
There was a problem hiding this comment.
inspect review
Triage: 20 entities analyzed | 0 critical, 0 high, 9 medium, 11 low
Verdict: standard_review
Findings (2)
- [low] MCP tool API breaking change:
EntitiesParamsrenamed from requiredfile_path: Stringto optionalpath: Option<String>, so existing callers sendingfile_pathwill fail to deserialize (missing field) and break at runtime. Evidence:crates/sem-mcp/src/tools.rschanged topub path: Option<String>andsem_entitiesnow readsparams.path. - [low] MCP directory mode silently skips unreadable/non-UTF8 files by ignoring
read_to_stringerrors, returning partial/incomplete entity lists without signaling failure. Evidence:crates/sem-mcp/src/server.rsdirectory branch:if let Ok(content) = std::fs::read_to_string(&abs_path) { all_entities.extend(...) }(no else/error).
Reviewed by inspect | Entity-level triage found 0 high-risk changes
Contributor
Author
|
these risks are fair @rs545837 do you like the general direction of this PR? Should I fix those? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sem entities now works via path, instead of being scoped to single files. this allows for repo-wide entity search across multiple files at once. The old calling shape remains the same, because "sem entities ./foo.ts" is, after all, also a path. By default, "sem entities" list all entities.
If only one file is found, no grouping happens.