fix: count the grid's commits on a property, not on the root element - #313
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The render counter added with N159 wrote
document.documentElement.dataset.gridRenderson every commit of the grid, and the grid commits with the playhead. An attribute written on<html>is the most expensive place to put one: it can cost the whole document a style recalculation, and the runner draws through llvmpipe. CI run 34689311401 then went red onvideo-frame-keys.spec.js, the whole file, on a forty second wait for a single frame step.The counter is a plain property now, which touches no DOM and invalidates nothing.
Said plainly: this is not a proved cause. That spec passes here, ten of ten, and the failure is the runner's alone. What is established is the other half: nothing in
srcdepends on the identity of the selection set, so the no-op that change also made cannot stop an effect from firing. What is left in it that touches the app at any rate is this counter, and the cost is gone rather than argued about.Changes
How to verify by using the app
Nothing changes on screen.
Verified on Linux. Full gate green, 87 spec files and 516 tests, verdict line GATE GREEN, and the N159 check still reads the count it is there to read.