feat: batch verification with ZK proof support (#458)#642
Merged
fejilaup-cloud merged 1 commit intoJun 17, 2026
Merged
Conversation
- Add hash aggregation logic combining multiple commitments into single deterministic proof - Implement incremental SHA-256 hashing for deterministic proof validation - Add constant-time comparison (constant_time_bytes_32_eq) to prevent timing side-channel attacks - Remove conflicting old tuple-based batch_verify_commitments (Issue AtomicIP#432) - Emit b_vfy event with aggregate proof and summary counts on batch completion - Store BatchVerifyResult on-chain keyed by aggregate proof hash - Update verify_commitment to use constant-time comparison - Add unit tests: valid/invalid proofs, empty batch, single item, event emission - Update test.rs trait and tests to use VerifyRequest/VerifyResult struct types - Update commitment-scheme.md with full batch verification flow documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements batch verification for Pedersen commitments with ZK proof support to handle multiple IP commitments simultaneously without revealing individual secrets.
Closes #458.