Speed up user social graph fields#893
Open
raymondjacobson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_social_sets) with a dirty queue maintained by a lightweightfollowstrigger.does_current_user_follow,does_follow_current_user,does_current_user_subscribe, andcurrent_user_followee_follow_counthydration out ofGetUsersSQL into Go using snapshots, with rawfollowsfallback for missing rows or pre-migration environments.followsresult for the moved fields.Performance context
GetUsers, the remaining base query on that sample was roughly 315ms cold I/O in production.followsfanout in the main SQL query.Indexing impact
user_social_set_dirtyper follow insert/update/delete.Validation
go test ./api -run 'TestUserQuery|TestGetUsers|TestUserQueryUsesSocialSetSnapshots|TestUserQuerySocialSetSnapshotsMatchFollows'go test ./jobs ./api/dbv1go test ./api ./api/dbv1 ./jobstest_api; a rerun in this final session was blocked because local Postgres was not listening on/tmp/.s.PGSQL.5432.